refactor: C4GH and storage changes #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of Arc<Mutex<..>>
Update
|
mmalenic
force-pushed
the
feat/c4gh-misc
branch
from
ba546cc
to
bca364f
Compare
Gotcha, probably worth holding to noodles release before merging this PR then? Two birds one shot? |
Nah, I'd like to get this merged so I can move on to the next PRs. It will be easy enough to fix in a different PR when it gets released. This could be a stand-alone dependency bump PR, or as part of a PR including features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
htsget-storage:StorageMiddlewarecontrols pre-processing and post-processing requests to the storage layer, which is used inC4GHStorageto decrypt/encrypt data.StorageCloneallows cloning aBox<dyn StorageTrait + Send + Sync + 'static>.Arc<Mutex<..>>insideC4GHStorage.C4GHStorage.c4gh-experimentaltoexperimental.